Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chromeos/dbus/fake_shill_device_client.cc

Issue 299403012: Clean up shill fake implementations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_shill_device_client.cc
diff --git a/chromeos/dbus/fake_shill_device_client.cc b/chromeos/dbus/fake_shill_device_client.cc
index dd0322f7eb9c88123ff0c5c6a7793cd0ac9128bc..bb26d8acb9b59bd52063616b1d53f5db1bea46b4 100644
--- a/chromeos/dbus/fake_shill_device_client.cc
+++ b/chromeos/dbus/fake_shill_device_client.cc
@@ -237,18 +237,17 @@ ShillDeviceClient::TestInterface* FakeShillDeviceClient::GetTestInterface() {
void FakeShillDeviceClient::AddDevice(const std::string& device_path,
const std::string& type,
- const std::string& object_path) {
+ const std::string& name) {
DBusThreadManager::Get()->GetShillManagerClient()->GetTestInterface()->
AddDevice(device_path);
base::DictionaryValue* properties = GetDeviceProperties(device_path);
properties->SetWithoutPathExpansion(shill::kTypeProperty,
base::Value::CreateStringValue(type));
+ properties->SetWithoutPathExpansion(shill::kNameProperty,
+ base::Value::CreateStringValue(name));
properties->SetWithoutPathExpansion(
- shill::kNameProperty,
- base::Value::CreateStringValue(object_path));
- properties->SetWithoutPathExpansion(
- shill::kDBusObjectProperty, base::Value::CreateStringValue(object_path));
+ shill::kDBusObjectProperty, base::Value::CreateStringValue(device_path));
properties->SetWithoutPathExpansion(
shill::kDBusServiceProperty,
base::Value::CreateStringValue(modemmanager::kModemManager1ServiceName));

Powered by Google App Engine
This is Rietveld 408576698