Clean up shill fake implementations

chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/chromeos/login/login_manager_test.h"
 #include "chrome/browser/chromeos/login/startup_utils.h"
 #include "chrome/browser/chromeos/login/test/oobe_screen_waiter.h"
 #include "chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
 #include "chrome/browser/chromeos/login/ui/webui_login_view.h"
 #include "chrome/browser/chromeos/net/network_portal_detector.h"
 #include "chrome/browser/chromeos/net/network_portal_detector_test_impl.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chromeos/chromeos_switches.h"
+#include "chromeos/dbus/fake_shill_manager_client.h"
 
 namespace chromeos {
 
 namespace {
 
-const char kStubEthernetServicePath[] = "eth1";
-
 // Stub implementation of CaptivePortalWindowProxyDelegate, does
 // nothing and used to instantiate CaptivePortalWindowProxy.
 class CaptivePortalWindowProxyStubDelegate
     : public CaptivePortalWindowProxyDelegate {
  public:
   CaptivePortalWindowProxyStubDelegate(): num_portal_notifications_(0) {
   }
 
   virtual ~CaptivePortalWindowProxyStubDelegate() {
   }
@@ skipping 146 matching lines @@
 
   virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
     LoginManagerTest::SetUpInProcessBrowserTestFixture();
 
     network_portal_detector_ = new NetworkPortalDetectorTestImpl();
     NetworkPortalDetector::InitializeForTesting(network_portal_detector_);
     NetworkPortalDetector::CaptivePortalState portal_state;
     portal_state.status = NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_PORTAL;
     portal_state.response_code = 200;
     network_portal_detector_->SetDefaultNetworkPathForTesting(
-        kStubEthernetServicePath);
+        FakeShillManagerClient::kFakeEthernetNetworkPath);
     network_portal_detector_->SetDetectionResultsForTesting(
-        kStubEthernetServicePath, portal_state);
+        FakeShillManagerClient::kFakeEthernetNetworkPath, portal_state);
   }
 
  protected:
   NetworkPortalDetectorTestImpl* network_portal_detector() {
     return network_portal_detector_;
   }
 
   PortalDetectorStrategy::StrategyId strategy_id() {
     return network_portal_detector_->strategy_id();
   }
@@ skipping 22 matching lines @@
 
   ASSERT_EQ(PortalDetectorStrategy::STRATEGY_ID_LOGIN_SCREEN, strategy_id());
   network_portal_detector()->NotifyObserversForTesting();
   OobeScreenWaiter(OobeDisplay::SCREEN_ERROR_MESSAGE).Wait();
   ASSERT_EQ(PortalDetectorStrategy::STRATEGY_ID_ERROR_SCREEN, strategy_id());
 
   actor->ShowCaptivePortal();
 }
 
 }  // namespace chromeos