Issue 299403008: Fix storing to primitive objects by applying ToObject. This is necessary to ensure that we properly…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Chromium Code Reviews

Issue 299403008: Fix storing to primitive objects by applying ToObject. This is necessary to ensure that we properly… (Closed)

Created:
6 years, 7 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix storing to primitive objects by applying ToObject. This is necessary to ensure that we properly traverse the prototype chain of their value wrappers. BUG=v8:1475 LOG=n

Patch Set 1 #

Patch Set 2 : Adding test #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -2 lines)			Patch
	M	src/ic.cc	View		1 chunk	+17 lines, -2 lines	0 comments	Download
	A	test/mjsunit/assign-primitive-property.js	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download