Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Unified Diff: net/socket/socket_test_util.h

Issue 2994003: Refactor how ClientSocketPoolBaseHelper avoids re-entrancy. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Merge. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/client_socket_pool_base_unittest.cc ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.h
diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h
index b9c0f0cb49e1106fbbae2b00cbde3ebe8fc9e72b..bb52c0ca00c844bc57475be999693408502df33c 100644
--- a/net/socket/socket_test_util.h
+++ b/net/socket/socket_test_util.h
@@ -635,8 +635,8 @@ class MockTCPClientSocketPool : public TCPClientSocketPool {
const scoped_refptr<ClientSocketPoolHistograms>& histograms,
ClientSocketFactory* socket_factory);
- int release_count() { return release_count_; };
- int cancel_count() { return cancel_count_; };
+ int release_count() const { return release_count_; };
+ int cancel_count() const { return cancel_count_; };
// TCPClientSocketPool methods.
virtual int RequestSocket(const std::string& group_name,
@@ -647,7 +647,7 @@ class MockTCPClientSocketPool : public TCPClientSocketPool {
const BoundNetLog& net_log);
virtual void CancelRequest(const std::string& group_name,
- const ClientSocketHandle* handle);
+ ClientSocketHandle* handle);
virtual void ReleaseSocket(const std::string& group_name,
ClientSocket* socket, int id);
@@ -680,7 +680,7 @@ class MockSOCKSClientSocketPool : public SOCKSClientSocketPool {
const BoundNetLog& net_log);
virtual void CancelRequest(const std::string& group_name,
- const ClientSocketHandle* handle);
+ ClientSocketHandle* handle);
virtual void ReleaseSocket(const std::string& group_name,
ClientSocket* socket, int id);
« no previous file with comments | « net/socket/client_socket_pool_base_unittest.cc ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698