Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: net/socket/socks_client_socket_pool.h

Issue 2994003: Refactor how ClientSocketPoolBaseHelper avoids re-entrancy. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Merge. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/socket/socket_test_util.cc ('k') | net/socket/socks_client_socket_pool.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_ 5 #ifndef NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_
6 #define NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_ 6 #define NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 // ClientSocketPool methods: 115 // ClientSocketPool methods:
116 virtual int RequestSocket(const std::string& group_name, 116 virtual int RequestSocket(const std::string& group_name,
117 const void* connect_params, 117 const void* connect_params,
118 RequestPriority priority, 118 RequestPriority priority,
119 ClientSocketHandle* handle, 119 ClientSocketHandle* handle,
120 CompletionCallback* callback, 120 CompletionCallback* callback,
121 const BoundNetLog& net_log); 121 const BoundNetLog& net_log);
122 122
123 virtual void CancelRequest(const std::string& group_name, 123 virtual void CancelRequest(const std::string& group_name,
124 const ClientSocketHandle* handle); 124 ClientSocketHandle* handle);
125 125
126 virtual void ReleaseSocket(const std::string& group_name, 126 virtual void ReleaseSocket(const std::string& group_name,
127 ClientSocket* socket, 127 ClientSocket* socket,
128 int id); 128 int id);
129 129
130 virtual void Flush(); 130 virtual void Flush();
131 131
132 virtual void CloseIdleSockets(); 132 virtual void CloseIdleSockets();
133 133
134 virtual int IdleSocketCount() const { 134 virtual int IdleSocketCount() const {
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 PoolBase base_; 184 PoolBase base_;
185 185
186 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketPool); 186 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketPool);
187 }; 187 };
188 188
189 REGISTER_SOCKET_PARAMS_FOR_POOL(SOCKSClientSocketPool, SOCKSSocketParams); 189 REGISTER_SOCKET_PARAMS_FOR_POOL(SOCKSClientSocketPool, SOCKSSocketParams);
190 190
191 } // namespace net 191 } // namespace net
192 192
193 #endif // NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_ 193 #endif // NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_
OLDNEW
« no previous file with comments | « net/socket/socket_test_util.cc ('k') | net/socket/socks_client_socket_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698