Issue 2993963003: Reverts IsolateReload commits that marked two tests as crashing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2993963003: Reverts IsolateReload commits that marked two tests as crashing. (Closed)

Created:
3 years, 4 months ago by danunez

Modified:
3 years, 4 months ago

Reviewers:
regis, rmacnak, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Reverts IsolateReload commits that marked two tests as crashing. This is a part of the revert in 91662ce57927. Revert "Mark vm/cc/IsolateReload_ClassFieldRemoved as crashing on dartk-vm." This reverts commit 51229000e39fad947f23292ed073491f7361bb6d. Revert "Mark vm/cc/IsolateReload_ClassFieldRemoved as crashing on dartk-vm." This reverts commit 969ad4f622d5b1ce291d34b2eab2fbc7607950a2. BUG= Committed: https://github.com/dart-lang/sdk/commit/d6f4895aa5a7c4449794d696e619367721ba1297

Patch Set 1 #

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	runtime/tests/vm/vm.status	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

danunez

3 years, 4 months ago (2017-08-08 23:03:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d6f4895aa5a7c4449794d696e619367721ba1297 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages