Use ExtensionRegistryObserver instead of deprecated extension notification from c/b/extension

Use ExtensionRegistryObserver instead of deprecated extension notification from c/b/extension
alarm, commands, declartive, storage api and extension_gcm_app_handler.

Also, removed unwanted extension:: namespace prefix.

R=rdevlin.cronin@chromium.org
BUG=376293
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273829

[limasdf, 2014-05-25 14:56:27]

please take a look when you have time.

[Devlin, 2014-05-28 16:58:34]

Just a few small nits. :)

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
File chrome/browser/extensions/api/commands/command_service.cc (left):

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
chrome/browser/extensions/api/commands/command_service.cc:26: #include
"content/public/browser/notification_details.h"
We still want this because of the content::Details on line 298.

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
File chrome/browser/extensions/api/commands/command_service.cc (right):

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
chrome/browser/extensions/api/commands/command_service.cc:35: namespace
extensions {
Thanks :)

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
File chrome/browser/extensions/api/storage/managed_value_store_cache.cc (right):

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
chrome/browser/extensions/api/storage/managed_value_store_cache.cc:137: const
Extension* extension) {
I don't _think_ this can ever happen, but the if statement on line 130 used to
break in both notifications, whereas now the OnExtensionUninstalled still
executes.  Could you either make sure that an extension can never be uninstalled
if the system isn't ready (you wouldn't think it could/should happen, but you
never know), or add the check here, too?

[limasdf, 2014-05-28 17:38:42]

Thank you for the review! :)
PTAL

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
File chrome/browser/extensions/api/commands/command_service.cc (left):

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
chrome/browser/extensions/api/commands/command_service.cc:26: #include
"content/public/browser/notification_details.h"
On 2014/05/28 16:58:34, Devlin wrote:
> We still want this because of the content::Details on line 298.

Done.

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
File chrome/browser/extensions/api/storage/managed_value_store_cache.cc (right):

https://codereview.chromium.org/299393002/diff/100001/chrome/browser/extensio...
chrome/browser/extensions/api/storage/managed_value_store_cache.cc:137: const
Extension* extension) {
On 2014/05/28 16:58:34, Devlin wrote:
> I don't _think_ this can ever happen, but the if statement on line 130 used to
> break in both notifications, whereas now the OnExtensionUninstalled still
> executes.  Could you either make sure that an extension can never be
uninstalled
> if the system isn't ready (you wouldn't think it could/should happen, but you
> never know), or add the check here, too?

Done.
The reason why I removed is the comment says 'extesnions are installed'.
But obviously code doesn't cover only extension installed event. :)

[limasdf, 2014-05-28 17:42:06]

Hm, sorry. I have to update OnExtensionWillBeInstalled parameter because the
parameter is updated recently.

after updating code, I'll request review again!

[limasdf, 2014-05-29 01:40:07]

PTAL.

[Devlin, 2014-05-29 15:36:32]

lgtm!

[limasdf, 2014-05-29 15:37:14]

Thank you!

[limasdf, 2014-05-29 15:37:18]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-29 15:39:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/299393002/160001

[commit-bot: I haz the power, 2014-05-29 17:30:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/10517)

[commit-bot: I haz the power, 2014-05-29 17:37:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 17:37:35]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/10560)

[limasdf, 2014-05-30 07:33:07]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-30 07:34:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/299393002/160001

[commit-bot: I haz the power, 2014-05-30 07:54:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/10886)

[commit-bot: I haz the power, 2014-05-30 08:00:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 08:00:03]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/10893)

[limasdf, 2014-05-30 11:33:11]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-30 11:33:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/299393002/190001

[commit-bot: I haz the power, 2014-05-30 13:20:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-05-30 14:59:44]

Change committed as 273829