Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: tools/gardening/bin/current_summary.dart

Issue 2993913002: Add filtering to 'summary' (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gardening/bin/summary.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/bin/current_summary.dart
diff --git a/tools/gardening/bin/current_summary.dart b/tools/gardening/bin/current_summary.dart
index 287c6fcaa66f3ae78e4f9168c202879d8950bbd5..ff9520d4f6b1007c6e956189bbdf1ab5214b17ea 100644
--- a/tools/gardening/bin/current_summary.dart
+++ b/tools/gardening/bin/current_summary.dart
@@ -19,7 +19,6 @@ import 'package:gardening/src/util.dart';
void help(ArgParser argParser) {
print('Displays the current status of specific tests on the buildbot');
- print('Only prints output for failing tests.');
print('The test-names may be fully qualified (such as in ');
print('"pkg/front_end/test/token_test") or just be a substring of the fully');
print(' qualified name.');
@@ -28,18 +27,6 @@ void help(ArgParser argParser) {
print(argParser.usage);
}
-/// Checks that [haystack] contains substring [needle], case insensitive.
-/// Throws an exception if either parameter is `null`.
-bool containsIgnoreCase(String haystack, String needle) {
- if (haystack == null) {
- throw "Unexpected null as the first paramter value of containsIgnoreCase";
- }
- if (needle == null) {
- throw "Unexpected null as the second parameter value of containsIgnoreCase";
- }
- return haystack.toLowerCase().contains(needle.toLowerCase());
-}
-
main(List<String> args) async {
ArgParser argParser = createArgParser();
argParser.addOption('group',
@@ -74,7 +61,7 @@ main(List<String> args) async {
// http, i.e. always use build number `-1`.
List<BuildUri> uriList = group.createUris(bot.mostRecentBuildNumber);
if (uriList.isEmpty) continue;
- print('Fetching ${uriList.first} + ${uriList.length - 1} more ...');
+ print('Fetching "${uriList.first}" + ${uriList.length - 1} more ...');
List<BuildResult> results = await bot.readResults(uriList);
bool testsFoundInGroup = false;
for (BuildResult buildResult in results) {
« no previous file with comments | « no previous file | tools/gardening/bin/summary.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698