Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2993893002: dedup tests/corelib_2/corelib_2.status dart2js entries (Closed)

Created:
3 years, 4 months ago by sra1
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dedup tests/corelib_2/corelib_2.status dart2js entries TBR=sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e6065258941533c43e01149287385cd23e4788f7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -100 lines) Patch
M tests/corelib/corelib.status View 5 chunks +0 lines, -5 lines 1 comment Download
M tests/corelib_2/corelib_2.status View 14 chunks +42 lines, -95 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
sra1
Committed patchset #1 (id:20001) manually as e6065258941533c43e01149287385cd23e4788f7 (presubmit successful).
3 years, 4 months ago (2017-08-07 23:27:25 UTC) #5
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-07 23:29:55 UTC) #6
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/2993893002/diff/20001/tests/corelib/corelib.s...
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/2993893002/diff/20001/tests/corelib/corelib.s...
tests/corelib/corelib.status:243: error_stack_trace1_test: Pass # Issue 27394
delete? it seems a bit odd to have a `pass` here

Powered by Google App Engine
This is Rietveld 408576698