Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2993883002: Implement type inference for named function expressions. (Closed)

Created:
3 years, 4 months ago by Paul Berry
Modified:
3 years, 4 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement type inference for named function expressions. Named function expressions are not legal in Dart, but they are accepted by the Fasta parser and BodyBuilder for error recovery purposes, so the type inference engine needs to support them. R=ahe@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2e907860912686b30b8127d96721276b9af3504a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/regress/issue_29937.dart.strong.expect View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/regress/issue_29978.dart.strong.expect View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/regress/issue_29979.dart.strong.expect View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
I only need a review from one of you.
3 years, 4 months ago (2017-08-07 21:28:18 UTC) #2
Paul Berry
I only need a review from one of you.
3 years, 4 months ago (2017-08-07 21:28:19 UTC) #3
scheglov
lgtm
3 years, 4 months ago (2017-08-07 21:30:56 UTC) #4
ahe
lgtm
3 years, 4 months ago (2017-08-08 13:25:21 UTC) #5
Paul Berry
3 years, 4 months ago (2017-08-08 17:02:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e907860912686b30b8127d96721276b9af3504a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698