[dart:io] Ignore server http upgrade request unless status code is right

[dart:io] Ignore server http upgrade request unless status code is right

fixes #30338

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/21eddc429e9c7260de00a9af7cad94baba830f59

[zra, 2017-08-07 20:56:51]

zra@google.com changed reviewers:
+ asiva@google.com, jsimmons@google.com, sgjesse@google.com, yjbanov@google.com

[eseidel1, 2017-08-07 21:27:49]

Is there an HTTP test suite (maybe from chrome?) that would have caught this
edge-case?

[siva, 2017-08-07 21:30:20]

lgtm

https://codereview.chromium.org/2993873002/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/2993873002/diff/1/sdk/lib/io/http_parser.dart...
sdk/lib/io/http_parser.dart:670: _statusCode == HttpStatus.SWITCHING_PROTOCOLS;
Not sure about Dart coding standards but would make sense to add parens around
the conditions for better readability
(_statusCode == ...) || (_statusCode == ...)

[zra, 2017-08-07 22:00:41]

On 2017/08/07 21:27:49, eseidel1 wrote:
> Is there an HTTP test suite (maybe from chrome?) that would have caught this
> edge-case?

That's a good question. I don't know. A few Google searches didn't turn anything
up. If there's a point of contact on the Chrome team for that sort of thing,
that could be useful.

[zra, 2017-08-07 22:08:54]

Description was changed from

==========
[dart:io] Ignore server http upgrade request unless status code is right

fixes #30338
==========

to

==========
[dart:io] Ignore server http upgrade request unless status code is right

fixes #30338

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/21eddc429e9c7260de00a9af7cad94baba830f59
==========

[zra, 2017-08-07 22:08:55]

Committed patchset #1 (id:1) manually as
21eddc429e9c7260de00a9af7cad94baba830f59 (presubmit successful).

[zra, 2017-08-07 22:09:04]

https://codereview.chromium.org/2993873002/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/2993873002/diff/1/sdk/lib/io/http_parser.dart...
sdk/lib/io/http_parser.dart:670: _statusCode == HttpStatus.SWITCHING_PROTOCOLS;
On 2017/08/07 21:30:19, siva wrote:
> Not sure about Dart coding standards but would make sense to add parens around
> the conditions for better readability
> (_statusCode == ...) || (_statusCode == ...)

Couldn't find any guidance in the style guide, but I added the parens for
grouping.