Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2993793003: [scheduler]: ACLs phase 3 - require ACLs specs for each Job/Trigger. (Closed)

Created:
3 years, 4 months ago by tandrii(chromium)
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[scheduler]: ACLs phase 3 - require ACLs specs for each Job/Trigger. BUG=736770

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : pylint #

Patch Set 4 : rebase #

Patch Set 5 : Updated patchset dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -45 lines) Patch
M scheduler/appengine/acl/acl.go View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M scheduler/appengine/acl/acl_test.go View 1 2 2 chunks +13 lines, -7 lines 0 comments Download
M scheduler/appengine/engine/engine_test.go View 1 2 3 3 chunks +8 lines, -31 lines 0 comments Download

Depends on Patchset:

Issue 2993813002 Patch 20001

Messages

Total messages: 20 (17 generated)
tandrii(chromium)
ptal
3 years, 4 months ago (2017-08-08 12:29:00 UTC) #12
Vadim Sh.
lgtm, assuming you'll fix all existing configs...
3 years, 4 months ago (2017-08-08 19:09:22 UTC) #19
tandrii(chromium)
3 years, 4 months ago (2017-08-10 21:16:45 UTC) #20

Powered by Google App Engine
This is Rietveld 408576698