Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2993783002: Mark vm/cc/IsolateReload_ClassFieldRemoved as crashing on dartk-vm. (Closed)

Created:
3 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 4 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark vm/cc/IsolateReload_ClassFieldRemoved as crashing on dartk-vm in debug mode, two tests as passing in release mode.. Gardening. R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/51229000e39fad947f23292ed073491f7361bb6d Committed: https://github.com/dart-lang/sdk/commit/969ad4f622d5b1ce291d34b2eab2fbc7607950a2

Patch Set 1 #

Patch Set 2 : Fix the fix. The crash is only in debug mode, the release mode fixes things. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/tests/vm/vm.status View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lasse Reichstein Nielsen
3 years, 4 months ago (2017-08-07 07:39:12 UTC) #2
eernst
lgtm
3 years, 4 months ago (2017-08-07 07:39:51 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 51229000e39fad947f23292ed073491f7361bb6d (presubmit successful).
3 years, 4 months ago (2017-08-07 07:57:43 UTC) #5
Lasse Reichstein Nielsen
3 years, 4 months ago (2017-08-07 09:05:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
969ad4f622d5b1ce291d34b2eab2fbc7607950a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698