Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2553)

Unified Diff: dashboard/dashboard/elements/group-report-page.html

Issue 2993773002: Dashboard charts: display sparklines of related timeseries in a tab strip. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/elements/group-report-page.html
diff --git a/dashboard/dashboard/elements/group-report-page.html b/dashboard/dashboard/elements/group-report-page.html
index 881a46aa71f7c57bc93ceb6083359ed47cff4aa8..93607e57c329f4c8bfcb30c27dbf502a5535f267 100644
--- a/dashboard/dashboard/elements/group-report-page.html
+++ b/dashboard/dashboard/elements/group-report-page.html
@@ -213,12 +213,28 @@ found in the LICENSE file.
listeners: {
openReportPage: 'openReportPage_',
+ promoteSparkLine: 'promoteSparkLine_',
},
openReportPage_(event) {
window.open(event.detail.url, '_blank');
},
+ promoteSparkLine_(event) {
+ const chart = document.createElement('chart-container');
+ const containerElement = this.$['charts-container'];
+ Polymer.dom(containerElement).appendChild(chart);
+ chart.graphParams = {
+ start_rev: event.detail.startRev,
+ end_rev: event.detail.endRev,
+ };
+ for (const testpath of event.detail.testpaths) {
+ chart.addSeriesGroup2(new d.SeriesGroup(
+ testpath.testpath, [testpath.testpath], []), true);
+ }
+ this.setChartData(chart);
+ },
+
get alertsTable() {
return this.$['alerts-table'];
},

Powered by Google App Engine
This is Rietveld 408576698