Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2993773002:
Dashboard charts: display sparklines of related timeseries in a tab strip. (Closed)
|
Created:
3 years, 4 months ago by benjhayden Modified:
3 years, 3 months ago CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionDashboard charts: display sparklines of related timeseries in a tab strip.
Currently, there are 2 main ways that users explore related timeseries on the
chromeperf dashboard:
1. manually build bookmarkable reports containing all of the related timeseries in
many many charts,
2. manually use the test-picker to find a specific related chart, look at it to see
if it's the right chart, and repeat if not.
Both of these methods are time-consuming for users.
This CL introduces a tab strip below each chart that automatically loads all
related timeseries in spark-lines. Users can simply scroll through the sparklines
and click to promote it to a full chart.
Tabs in this tab strip correspond to dimensions of test paths:
- Bots
- Stories
- Story tags
- Metric relationship dimensions such as
- Process type
- Chrome component
This CL only implements the memory metric relationship dimensions.
https://dev-benjhayden-19d7ef16-dot-chromeperf.appspot.com/report?sid=4a565ec69501908a575b892167ae573f3db5b077f34d3a2c2040e7cc364f8641&3405=y
https://dev-benjhayden-19d7ef16-dot-chromeperf.appspot.com/report?sid=4a565ec69501908a575b892167ae573f3db5b077f34d3a2c2040e7cc364f8641&3405=y&slyamax=-1
BUG=catapult:#3405
Review-Url: https://chromiumcodereview.appspot.com/2993773002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7a80ad3406d181fb821a043c975a16c79b8e0c61
Patch Set 1 : #Patch Set 2 : #
Total comments: 3
Patch Set 3 : #Patch Set 4 : comments #
Total comments: 3
Patch Set 5 : #
Total comments: 3
Patch Set 6 : rename chart-sparkline #Patch Set 7 : fix warnings[].value #Messages
Total messages: 82 (73 generated)
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - open chart when sparkline clicked - vertical line at selected revision - synchronize zoom/pan BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - open chart when sparkline clicked - vertical line at selected revision - synchronize zoom/pan BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - open chart when sparkline clicked - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-2202e36d-dot-chromeperf.appspot.com/report?sid=7718ace... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - open chart when sparkline clicked - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-2202e36d-dot-chromeperf.appspot.com/report?sid=7718ace... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - open chart when sparkline clicked - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-2993773002-dot-chromeperf.appspot.com/report?sid=7718a... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - open chart when sparkline clicked - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-2993773002-dot-chromeperf.appspot.com/report?sid=7718a... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - open chart when sparkline clicked - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-4ec3916e-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - open chart when sparkline clicked - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-4ec3916e-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision - synchronize zoom/pan - Material Tile https://dev-benjhayden-4ec3916e-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
Patchset #1 (id:120001) has been deleted
Patchset #1 (id:140001) has been deleted
Patchset #1 (id:160001) has been deleted
Patchset #1 (id:180001) has been deleted
Patchset #1 (id:200001) has been deleted
Patchset #1 (id:220001) has been deleted
Patchset #1 (id:240001) has been deleted
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision - synchronize zoom/pan - Material Tile https://dev-benjhayden-4ec3916e-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - rebuild related tabs and re-select tab when timeseries enabled/disabled - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-4ec3916e-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ==========
Patchset #1 (id:260001) has been deleted
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - rebuild related tabs and re-select tab when timeseries enabled/disabled - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-4ec3916e-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - rebuild related tabs and re-select tab when timeseries enabled/disabled - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-479a0614-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - rebuild related tabs and re-select tab when timeseries enabled/disabled - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-479a0614-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - rebuild related tabs and re-select tab when timeseries enabled/disabled - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-8585f9aa-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ==========
Patchset #1 (id:280001) has been deleted
Patchset #1 (id:300001) has been deleted
Patchset #1 (id:320001) has been deleted
Patchset #1 (id:340001) has been deleted
Patchset #1 (id:360001) has been deleted
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - rebuild related tabs and re-select tab when timeseries enabled/disabled - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-8585f9aa-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision - synchronize zoom/pan - fix promote https://dev-benjhayden-8585f9aa-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision - synchronize zoom/pan - fix promote https://dev-benjhayden-8585f9aa-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-8585f9aa-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-8585f9aa-dot-chromeperf.appspot.com/group_report?keys=... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-46a15445-dot-chromeperf.appspot.com BUG=catapult:#3405 ==========
Patchset #1 (id:380001) has been deleted
Patchset #1 (id:400001) has been deleted
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision - synchronize zoom/pan https://dev-benjhayden-46a15445-dot-chromeperf.appspot.com BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision https://dev-benjhayden-46a15445-dot-chromeperf.appspot.com BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision https://dev-benjhayden-46a15445-dot-chromeperf.appspot.com BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision https://dev-benjhayden-1247f98f-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ==========
Patchset #1 (id:420001) has been deleted
chrisbendeler@gmail.com changed reviewers: + chrisbendeler@gmail.com
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - vertical line at selected revision https://dev-benjhayden-1247f98f-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - fix x-axis, vertical line at selected revision Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component https://dev-benjhayden-1247f98f-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ==========
benjhayden@chromium.org changed reviewers: - chrisbendeler@gmail.com
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - fix x-axis, vertical line at selected revision Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component https://dev-benjhayden-1247f98f-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - fix x-axis Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component https://dev-benjhayden-1247f98f-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - fix x-axis Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component https://dev-benjhayden-1247f98f-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - fix x-axis Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-1247f98f-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - fix x-axis Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-1247f98f-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - fix x-axis Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-5e44d419-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. TODO: - fix x-axis Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-5e44d419-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-be9e56b2-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ==========
Patchset #1 (id:440001) has been deleted
Patchset #1 (id:460001) has been deleted
Patchset #1 (id:480001) has been deleted
Patchset #1 (id:500001) has been deleted
Patchset #1 (id:520001) has been deleted
Patchset #1 (id:540001) has been deleted
Patchset #1 (id:560001) has been deleted
Patchset #1 (id:580001) has been deleted
Patchset #1 (id:600001) has been deleted
Patchset #1 (id:620001) has been deleted
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build reports containing all of the related timeseries in lots and lots of charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines that are significantly easier for users to explore. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-be9e56b2-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-be9e56b2-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ==========
Patchset #1 (id:640001) has been deleted
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-be9e56b2-dot-chromeperf.appspot.com/report?sid=2e990a7... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-5d4212e2-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ==========
Patchset #1 (id:660001) has been deleted
Patchset #1 (id:680001) has been deleted
Patchset #1 (id:700001) has been deleted
Patchset #1 (id:720001) has been deleted
Patchset #1 (id:740001) has been deleted
Patchset #1 (id:760001) has been deleted
Patchset #1 (id:780001) has been deleted
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-5d4212e2-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-c5cbad1d-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ==========
benjhayden@chromium.org changed reviewers: + eakuefner@chromium.org, simonhatch@chromium.org
Please start reviewing while I tweak the visuals per the feedback from the services weekly.
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-c5cbad1d-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-86e5d913-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ==========
overall think this lg2m % gating it behind a flag + more comments Biggest comment is that it'd help a lot if you added more comments. When we stepped through over vc, there were a lot of comments from you explaining things like "I had to do it this way because of X refactor, so check both these, or had to check the value of this again since it might have changed (I think that was in spark-line)." Document those so that whoever goes through here next doesn't need to vc with you. https://codereview.chromium.org/2993773002/diff/820001/dashboard/dashboard/el... File dashboard/dashboard/elements/chart-container.html (right): https://codereview.chromium.org/2993773002/diff/820001/dashboard/dashboard/el... dashboard/dashboard/elements/chart-container.html:24: <link rel="import" href="/dashboard/elements/spark-line.html"> nit: naming convention here seems to be chart-<>, maybe this should be chart-spark-line or something to that effect. https://codereview.chromium.org/2993773002/diff/820001/dashboard/dashboard/el... dashboard/dashboard/elements/chart-container.html:2278: left += 5; nit: the line isn't quite centered over the points, adding about 1.5 solved that. https://codereview.chromium.org/2993773002/diff/820001/dashboard/dashboard/el... dashboard/dashboard/elements/chart-container.html:2920: this.async(() => { Q: Why is this async?
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-86e5d913-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-b6343bbd-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-b6343bbd-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-b6343bbd-dot-chromeperf.appspot.com/report?sid=4a565ec... https://dev-benjhayden-b6343bbd-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ==========
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-b6343bbd-dot-chromeperf.appspot.com/report?sid=4a565ec... https://dev-benjhayden-b6343bbd-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-5d522879-dot-chromeperf.appspot.com/report?sid=4a565ec... https://dev-benjhayden-5d522879-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ==========
Thanks! PTAL
lgtm https://codereview.chromium.org/2993773002/diff/860001/dashboard/dashboard/el... File dashboard/dashboard/elements/chart-container.html (right): https://codereview.chromium.org/2993773002/diff/860001/dashboard/dashboard/el... dashboard/dashboard/elements/chart-container.html:218: <img src="//www.google.com/images/loading.gif"> Isn't there a Catapult bug about this? https://codereview.chromium.org/2993773002/diff/860001/dashboard/dashboard/el... dashboard/dashboard/elements/chart-container.html:2938: this.async(() => { TODO about observer node? https://codereview.chromium.org/2993773002/diff/860001/dashboard/dashboard/el... File dashboard/dashboard/elements/report-page.html (right): https://codereview.chromium.org/2993773002/diff/860001/dashboard/dashboard/el... dashboard/dashboard/elements/report-page.html:158: new d.SeriesGroup(t.testpath, [t.testpath], []))); indentation is odd?
Done, thanks!
lgtm https://codereview.chromium.org/2993773002/diff/880001/dashboard/dashboard/el... File dashboard/dashboard/elements/chart-container.html (right): https://codereview.chromium.org/2993773002/diff/880001/dashboard/dashboard/el... dashboard/dashboard/elements/chart-container.html:24: <link rel="import" href="/dashboard/elements/spark-line.html"> nit: convention seems to be chart-<foo> for all these. https://codereview.chromium.org/2993773002/diff/880001/dashboard/dashboard/el... dashboard/dashboard/elements/chart-container.html:979: if (value.value) value = value.value; nit: What was this for again? https://codereview.chromium.org/2993773002/diff/880001/dashboard/dashboard/el... dashboard/dashboard/elements/chart-container.html:2930: this.set('selectedRelatedTab', []); Hrm, seems a bit magic, kinda would like to know why, but won't block on it.
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-5d522879-dot-chromeperf.appspot.com/report?sid=4a565ec... https://dev-benjhayden-5d522879-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-19d7ef16-dot-chromeperf.appspot.com/report?sid=4a565ec... https://dev-benjhayden-19d7ef16-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ==========
The CQ bit was checked by benjhayden@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eakuefner@chromium.org, simonhatch@chromium.org Link to the patchset: https://codereview.chromium.org/2993773002/#ps920001 (title: "fix warnings[].value")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 920001, "attempt_start_ts": 1504899999804370,
"parent_rev": "12fd4ba90cbda6bf7347688c20d9b1140bfb010f", "commit_rev":
"7a80ad3406d181fb821a043c975a16c79b8e0c61"}
Message was sent while issue was closed.
Description was changed from ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-19d7ef16-dot-chromeperf.appspot.com/report?sid=4a565ec... https://dev-benjhayden-19d7ef16-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 ========== to ========== Dashboard charts: display sparklines of related timeseries in a tab strip. Currently, there are 2 main ways that users explore related timeseries on the chromeperf dashboard: 1. manually build bookmarkable reports containing all of the related timeseries in many many charts, 2. manually use the test-picker to find a specific related chart, look at it to see if it's the right chart, and repeat if not. Both of these methods are time-consuming for users. This CL introduces a tab strip below each chart that automatically loads all related timeseries in spark-lines. Users can simply scroll through the sparklines and click to promote it to a full chart. Tabs in this tab strip correspond to dimensions of test paths: - Bots - Stories - Story tags - Metric relationship dimensions such as - Process type - Chrome component This CL only implements the memory metric relationship dimensions. https://dev-benjhayden-19d7ef16-dot-chromeperf.appspot.com/report?sid=4a565ec... https://dev-benjhayden-19d7ef16-dot-chromeperf.appspot.com/report?sid=4a565ec... BUG=catapult:#3405 Review-Url: https://chromiumcodereview.appspot.com/2993773002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:920001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
