fix corelib_2/iterable_to_set_test to reflect strong mode runtime checks

tests/corelib_2/corelib_2.status

 # Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # All static_tests have expected compile-time errors.
 [ $strong && $compiler != dart2analyzer && $compiler != dartdevc ]
 core_runtime_types_static_test: MissingCompileTimeError
 splay_tree_test/01: MissingCompileTimeError
 splay_tree_test/02: MissingCompileTimeError
 string_base_vm_static_test: MissingCompileTimeError
@@ skipping 147 matching lines @@
 compare_to2_test: RuntimeError, OK # Requires bigint support.
 hash_set_test/01: RuntimeError # Issue 11551
 int_modulo_arith_test/bignum: RuntimeError # Issue 29921
 int_modulo_arith_test/modPow: RuntimeError # Issue 29921
 regress_r21715_test: RuntimeError # Requires bigint support.
 int_parse_with_limited_ints_test: Skip # dart2js and dartdevc don't know about --limit-ints-to-64-bits
 typed_data_with_limited_ints_test: Skip # dart2js and dartdevc don't know about --limit-ints-to-64-bits
 
 [ $compiler == dart2js && $runtime != none ]
 nan_infinity_test/01: RuntimeError
+iterable_to_set_test: RuntimeError # is-checks do not implement strong mode type system

[Jennifer Messerly, 2017/08/04 23:33:11]

are there any other permutations I should test?

this test will fail on all Dart 1 platforms at runtime. (even DDC does not
implement it correctly yet, due to
https://github.com/dart-lang/sdk/issues/28988, because DDC's `is` checks attempt
to guard against divergence from the Dart 1 type system)

[Bob Nystrom, 2017/08/04 23:45:41]

If you run:

dart tools/migration/run_tests.dart iterable_to_set_test iterable_to_set_test

It will run just this test on a handful of configurations that we find useful
for the migration.
That's OK. We want correct tests and correct status files. If the test doesn't
pass, that's the implementer's problem. :)

[Jennifer Messerly, 2017/08/05 00:05:43]

thank you! did that & updated

 
 [ $compiler == dart2js && $runtime == drt && $csp && $minified ]
 core_runtime_types_test: Pass, Fail # Issue 27913
 
 [ $compiler != dartdevc ]
 error_stack_trace_test/static: MissingCompileTimeError
 
-[ $compiler == dartdevc ]
+[ $compiler == dartdevc && $runtime != none ]
 error_stack_trace_test/nullThrown: RuntimeError # .stackTrace not present for exception caught from 'throw null;'
 list_fill_range_test: RuntimeError # Issue 29921
 list_insert_test: RuntimeError # Issue 29921
 list_removeat_test: RuntimeError # Issue 29921
 list_replace_range_test: RuntimeError # Issue 29921
 list_set_all_test: RuntimeError # Issue 29921
 json_map_test: RuntimeError # Issue 29921
 
 [ $runtime == flutter ]
 apply3_test: CompileTimeError # mirrors not supported
@@ skipping 103 matching lines @@
 unicode_test: Fail
 
 [ ($runtime == vm || $runtime == dart_precompiled) && $arch == simarmv5te ]
 big_integer_parsed_mul_div_vm_test: Pass, SloW
 
 [ $compiler == precompiler ]
 big_integer_parsed_mul_div_vm_test: Pass, Timeout # --no_intrinsify
 
 [ $compiler == none && ($runtime == vm || $runtime == flutter)]
 string_trimlr_test/02: RuntimeError # Issue 29060
+iterable_to_set_test: RuntimeError # is-checks do not implement strong mode type system
 
 [ $compiler == precompiler || $compiler == app_jit ]
 string_trimlr_test/02: RuntimeError # Issue 29060
 
 # void should be a valid symbol.
 [ $compiler == none || $compiler == precompiler || $compiler == app_jit || ($compiler == dart2js && !$dart2js_with_kernel) ]
 symbol_reserved_word_test/02: CompileTimeError # Issue 20191
 
 # With the exception of 'void', const Symbol() should not accept reserved
 # words.
@@ skipping 711 matching lines @@
 list_unmodifiable_test: Pass, RuntimeError # Issue 28712
 iterable_to_list_test/01: RuntimeError # Issue 26501
 
 [ $compiler == dartk && $runtime == vm ]
 list_map_test: DartkCompileTimeError
 list_remove_range_test: DartkCompileTimeError
 list_replace_range_test: DartkCompileTimeError
 list_set_all_test: DartkCompileTimeError
 list_set_range_test: DartkCompileTimeError
 list_sublist_test: DartkCompileTimeError