src/x64/macro-assembler-x64.cc - Issue 299373005: Avoid HeapObject check in HStoreNamedField.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 299373005: Avoid HeapObject check in HStoreNamedField. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix condition on arm64. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index 6873efff67d39f7a948b634b24c4f9c768a79c30..f773a61bd5f1cb8e75b12aac7baed4a2456ae425 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -924,6 +924,11 @@ void MacroAssembler::Store(const Operand& dst, Register src, Representation r) {

} else if (r.IsInteger32()) {

movl(dst, src);

} else {

+ if (r.IsHeapObject()) {

+ AssertNotSmi(src);

+ } else if (r.IsSmi()) {

+ AssertSmi(src);

+ }

movp(dst, src);

}

« no previous file with comments | « src/x64/lithium-x64.cc ('k') | no next file » | no next file with comments »