Issue 299373002: Add GN build file for third_party speex library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299373002: Add GN build file for third_party speex library. (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, scottmg, awong, Dirk Pranke

Base URL:
http://src.chromium.org/svn/trunk/deps/third_party/speex

Visibility:
Public.

More Reviews

Description

Add GN build file for third_party speex library. This way we can hook it up in the GN build on Chromium. BUG=None TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn speex R=brettw@chromium.org Committed: 272757

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rm include #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -0 lines)			Patch
	A	BUILD.gn	View	1	1 chunk	+96 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://codereview.chromium.org/299373002/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/299373002/diff/20001/BUILD.gn#newcode78 BUILD.gn:78: "include", You don't need this "include" one since ...

6 years, 7 months ago (2014-05-25 03:20:11 UTC) #2

tfarina

https://codereview.chromium.org/299373002/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/299373002/diff/20001/BUILD.gn#newcode78 BUILD.gn:78: "include", On 2014/05/25 03:20:11, brettw wrote: > You don't ...

6 years, 7 months ago (2014-05-25 05:45:04 UTC) #3

tfarina

6 years, 7 months ago (2014-05-25 05:45:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r272757 (presubmit successful).

Expand Messages | Collapse Messages