Issue 2993713002: Move most code from AstInferrerEngine to InferrerEngineImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2993713002: Move most code from AstInferrerEngine to InferrerEngineImpl (Closed)

Created:
3 years, 4 months ago by Johnni Winther

Modified:
3 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+362 lines, -332 lines)			Patch
	M	pkg/compiler/lib/src/inferrer/ast_inferrer_engine.dart	View		3 chunks	+45 lines, -329 lines	0 comments	Download
	M	pkg/compiler/lib/src/inferrer/inferrer_engine.dart	View		4 chunks	+317 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

lgtm - seems like we went in a circle here :)

3 years, 4 months ago (2017-08-07 23:04:13 UTC) #3

Johnni Winther

3 years, 4 months ago (2017-08-09 08:03:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3ae6a43dbd889ddd93b62d3f287811b148c98dd9 (presubmit successful).