Fix flake in code_collection_test.

Fix flake in code_collection_test.

foo's code may be detached twice if the machine is slow/loaded and GC happens during shutdown.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/544713bceda0895f195b6da54cbf84a802b4efda

[rmacnak, 2017-08-04 00:44:21]

rmacnak@google.com changed reviewers:
+ zra@google.com

[rmacnak, 2017-08-04 00:44:21]

https://codereview.chromium.org/2993683002/diff/20001/tests/standalone/io/cod...
File tests/standalone/io/code_collection_test.dart (right):

https://codereview.chromium.org/2993683002/diff/20001/tests/standalone/io/cod...
tests/standalone/io/code_collection_test.dart:39: var ret = foo(2);
GC after returning here may collect the second compilation of foo.

[zra, 2017-08-04 05:19:43]

lgtm

https://codereview.chromium.org/2993683002/diff/20001/tests/standalone/io/cod...
File tests/standalone/io/code_collection_test.dart (right):

https://codereview.chromium.org/2993683002/diff/20001/tests/standalone/io/cod...
tests/standalone/io/code_collection_test.dart:39: var ret = foo(2);
On 2017/08/04 00:44:21, rmacnak wrote:
> GC after returning here may collect the second compilation of foo.

Maybe add this as a comment.

[rmacnak, 2017-08-04 17:33:44]

https://codereview.chromium.org/2993683002/diff/20001/tests/standalone/io/cod...
File tests/standalone/io/code_collection_test.dart (right):

https://codereview.chromium.org/2993683002/diff/20001/tests/standalone/io/cod...
tests/standalone/io/code_collection_test.dart:39: var ret = foo(2);
On 2017/08/04 05:19:43, zra wrote:
> On 2017/08/04 00:44:21, rmacnak wrote:
> > GC after returning here may collect the second compilation of foo.
> 
> Maybe add this as a comment.

Done.

[rmacnak, 2017-08-04 17:52:09]

Description was changed from

==========
Fix flake in code_collection_test.

foo's code may be detached twice if the machine is slow/loaded and GC happens
during shutdown.
==========

to

==========
Fix flake in code_collection_test.

foo's code may be detached twice if the machine is slow/loaded and GC happens
during shutdown.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/544713bceda0895f195b6da54cbf84a802b4efda
==========

[rmacnak, 2017-08-04 17:52:10]

Committed patchset #3 (id:40001) manually as
544713bceda0895f195b6da54cbf84a802b4efda (presubmit successful).