Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 299363002: Cleanup: Get rid of unneeded base::UTF16ToWide() conversions. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
sky, Wez
CC:
chromium-reviews, nkostylev+watch_chromium.org, chromoting-reviews_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Cleanup: Get rid of unneeded base::UTF16ToWide() conversions. It's a no-op in Windows-only code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274435

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : fix win #

Patch Set 5 : rebase again #

Patch Set 6 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -42 lines) Patch
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 3 4 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/memory_details_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager_util_win.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M components/breakpad/app/breakpad_win.cc View 1 2 3 4 5 3 chunks +7 lines, -11 lines 0 comments Download
M printing/printing_context_win.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M remoting/base/breakpad_win.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 2 6 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 33 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-24 04:58:09 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-27 15:52:11 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-27 17:02:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/299363002/20001
6 years, 7 months ago (2014-05-27 17:03:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 20:50:12 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 20:59:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69951)
6 years, 7 months ago (2014-05-27 20:59:06 UTC) #7
Lei Zhang
+wez for remoting/
6 years, 7 months ago (2014-05-27 21:11:41 UTC) #8
Wez
lgtm
6 years, 6 months ago (2014-05-28 22:33:54 UTC) #9
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-05-28 22:35:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/299363002/20001
6 years, 6 months ago (2014-05-28 22:37:26 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 01:02:51 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 01:15:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/20866)
6 years, 6 months ago (2014-05-29 01:15:05 UTC) #14
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-05-29 06:22:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/299363002/20001
6 years, 6 months ago (2014-05-29 06:23:25 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 06:35:14 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 06:43:35 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/23866) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/20992)
6 years, 6 months ago (2014-05-29 06:43:36 UTC) #19
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-05-29 07:41:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/299363002/40001
6 years, 6 months ago (2014-05-29 07:43:03 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 09:25:51 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 10:27:19 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/23885)
6 years, 6 months ago (2014-05-29 10:27:19 UTC) #24
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-05-31 17:29:11 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/299363002/60001
6 years, 6 months ago (2014-05-31 18:56:01 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 19:17:12 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-31 19:19:21 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/9310) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/190540) linux_chromium_chromeos_rel ...
6 years, 6 months ago (2014-05-31 19:19:21 UTC) #29
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-02 21:28:31 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/299363002/100001
6 years, 6 months ago (2014-06-02 21:29:23 UTC) #31
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 01:51:45 UTC) #32
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 08:46:52 UTC) #33
Message was sent while issue was closed.
Change committed as 274435

Powered by Google App Engine
This is Rietveld 408576698