Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2993603002: Updated test status after fixing closure call generation. (Closed)

Created:
3 years, 4 months ago by Emily Fortuna
Modified:
3 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updated test status after fixing closure call generation. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/6839f6f79fa26dc32e279820792fb66dc8f9b2b4

Patch Set 1 : . #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -139 lines) Patch
M pkg/compiler/lib/src/js_model/closure.dart View 1 2 3 4 3 chunks +33 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 5 chunks +0 lines, -8 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 4 32 chunks +13 lines, -113 lines 0 comments Download
M tests/language_2/language_2.status View 1 2 3 4 8 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Emily Fortuna
Review, or just tack on to your existing CL.
3 years, 4 months ago (2017-08-02 17:50:17 UTC) #3
Emily Fortuna
Okay, I did end up making a handful of edits to make some more tests ...
3 years, 4 months ago (2017-08-03 01:16:08 UTC) #5
Johnni Winther
LGTM - though I can't reproduce the status file changes. Currently I get very different ...
3 years, 4 months ago (2017-08-03 10:32:53 UTC) #6
Emily Fortuna
Committed patchset #5 (id:120001) manually as 6839f6f79fa26dc32e279820792fb66dc8f9b2b4 (presubmit successful).
3 years, 4 months ago (2017-08-03 17:45:23 UTC) #8
Emily Fortuna
3 years, 4 months ago (2017-08-03 17:51:46 UTC) #9
Message was sent while issue was closed. 
On 2017/08/03 17:45:23, Emily Fortuna wrote:
> Committed patchset #5 (id:120001) manually as
> 6839f6f79fa26dc32e279820792fb66dc8f9b2b4 (presubmit successful).

Johnni, perhaps you were running with the --minify flag? When you run without
the minify flag, you get these results.

Powered by Google App Engine
This is Rietveld 408576698