Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 299353007: Introduce the NewTabButtonTargeter class (Closed)

Created:
6 years, 7 months ago by tdanderson
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Visibility:
Public.

Description

Introduce the NewTabButtonTargeter class Introduce NewTabButtonTargeter, a derived class of MaskedViewTargeter, to define the custom hit-test region of the new tab button. BUG=377551 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274041

Patch Set 1 #

Patch Set 2 : rebase against ToT #

Patch Set 3 : rebase against ToT #

Patch Set 4 : DCHECK #

Patch Set 5 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -18 lines) Patch
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 3 4 4 chunks +47 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tdanderson
Scott, can you please take a look?
6 years, 6 months ago (2014-05-30 17:40:50 UTC) #1
sky
Can you elaborate as to why we're moving event targetting to a separate class. To ...
6 years, 6 months ago (2014-05-30 20:18:16 UTC) #2
sky
Terry filled me in on where he is trying to go. LGTM
6 years, 6 months ago (2014-05-30 20:49:02 UTC) #3
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 6 months ago (2014-05-30 20:52:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/299353007/80001
6 years, 6 months ago (2014-05-30 20:55:38 UTC) #5
tdanderson
The CQ bit was unchecked by tdanderson@chromium.org
6 years, 6 months ago (2014-05-30 20:56:16 UTC) #6
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 6 months ago (2014-05-30 20:56:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/299353007/80001
6 years, 6 months ago (2014-05-30 20:59:41 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 02:33:36 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-31 03:49:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/158573)
6 years, 6 months ago (2014-05-31 03:49:25 UTC) #11
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 6 months ago (2014-05-31 03:50:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/299353007/80001
6 years, 6 months ago (2014-05-31 03:53:26 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 05:15:29 UTC) #14
Message was sent while issue was closed. 
Change committed as 274041

Powered by Google App Engine
This is Rietveld 408576698