Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: Source/core/editing/VisibleSelection.cpp

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS() and make use of it Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/VisibleSelection.cpp
diff --git a/Source/core/editing/VisibleSelection.cpp b/Source/core/editing/VisibleSelection.cpp
index 6a79d0460bdb1014b6a2de6b0ee85b7dc1819002..f1b600aea5a8d5552422512c5aa836457841efee 100644
--- a/Source/core/editing/VisibleSelection.cpp
+++ b/Source/core/editing/VisibleSelection.cpp
@@ -136,7 +136,9 @@ VisibleSelection& VisibleSelection::operator=(const VisibleSelection& other)
VisibleSelection::~VisibleSelection()
{
+#if !ENABLE(OILPAN)
didChange();
+#endif
}
VisibleSelection VisibleSelection::selectionFromContentsOfNode(Node* node)
@@ -760,6 +762,14 @@ void VisibleSelection::didChange()
m_changeObserver->didChangeVisibleSelection();
}
+void VisibleSelection::trace(Visitor* visitor)
+{
+ visitor->trace(m_base);
+ visitor->trace(m_extent);
+ visitor->trace(m_start);
+ visitor->trace(m_end);
+}
+
#ifndef NDEBUG
void VisibleSelection::debugPosition() const

Powered by Google App Engine
This is Rietveld 408576698