Source/core/editing/InsertTextCommand.h - Issue 299353004: Oilpan: move editing objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertTextCommand.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + tidied Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/InsertTextCommand.h

diff --git a/Source/core/editing/InsertTextCommand.h b/Source/core/editing/InsertTextCommand.h

index 6356ff8b12ad1faa72ee64ba09fe6dc08fb6777c..3c282be1d92996b65609d7439c6275e0b18073bc 100644

--- a/Source/core/editing/InsertTextCommand.h

+++ b/Source/core/editing/InsertTextCommand.h

@@ -37,10 +37,10 @@ public:

RebalanceAllWhitespaces

};

- static PassRefPtr<InsertTextCommand> create(Document& document, const String& text, bool selectInsertedText = false,

+ static PassRefPtrWillBeRawPtr<InsertTextCommand> create(Document& document, const String& text, bool selectInsertedText = false,

RebalanceType rebalanceType = RebalanceLeadingAndTrailingWhitespaces)

{

- return adoptRef(new InsertTextCommand(document, text, selectInsertedText, rebalanceType));

+ return adoptRefWillBeNoop(new InsertTextCommand(document, text, selectInsertedText, rebalanceType));

}

private: