Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: Source/core/editing/SplitTextNodeCommand.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make test wrapper class finalized Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/SplitElementCommand.cpp ('k') | Source/core/editing/SplitTextNodeCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/SplitTextNodeCommand.h
diff --git a/Source/core/editing/SplitTextNodeCommand.h b/Source/core/editing/SplitTextNodeCommand.h
index 82e2854f9c87dcf2c316d1e381b85f05f59e1445..bef56eb206932d2f680298a5088140afabf33d26 100644
--- a/Source/core/editing/SplitTextNodeCommand.h
+++ b/Source/core/editing/SplitTextNodeCommand.h
@@ -34,11 +34,13 @@ class Text;
class SplitTextNodeCommand FINAL : public SimpleEditCommand {
public:
- static PassRefPtr<SplitTextNodeCommand> create(PassRefPtrWillBeRawPtr<Text> node, int offset)
+ static PassRefPtrWillBeRawPtr<SplitTextNodeCommand> create(PassRefPtrWillBeRawPtr<Text> node, int offset)
{
- return adoptRef(new SplitTextNodeCommand(node, offset));
+ return adoptRefWillBeNoop(new SplitTextNodeCommand(node, offset));
}
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
SplitTextNodeCommand(PassRefPtrWillBeRawPtr<Text>, int offset);
@@ -47,8 +49,8 @@ private:
virtual void doReapply() OVERRIDE;
void insertText1AndTrimText2();
- RefPtrWillBePersistent<Text> m_text1;
- RefPtrWillBePersistent<Text> m_text2;
+ RefPtrWillBeMember<Text> m_text1;
+ RefPtrWillBeMember<Text> m_text2;
unsigned m_offset;
};
« no previous file with comments | « Source/core/editing/SplitElementCommand.cpp ('k') | Source/core/editing/SplitTextNodeCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698