Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: Source/core/editing/RemoveNodeCommand.cpp

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make test wrapper class finalized Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/RemoveNodeCommand.h ('k') | Source/core/editing/RemoveNodePreservingChildrenCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/RemoveNodeCommand.cpp
diff --git a/Source/core/editing/RemoveNodeCommand.cpp b/Source/core/editing/RemoveNodeCommand.cpp
index cffc8c0b8da04ffb39ea7e2ed6e9172c39f02502..113b3063f251a7a9354222672fff5d0ebe42660f 100644
--- a/Source/core/editing/RemoveNodeCommand.cpp
+++ b/Source/core/editing/RemoveNodeCommand.cpp
@@ -32,7 +32,7 @@
namespace WebCore {
-RemoveNodeCommand::RemoveNodeCommand(PassRefPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
+RemoveNodeCommand::RemoveNodeCommand(PassRefPtrWillBeRawPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
: SimpleEditCommand(node->document())
, m_node(node)
, m_shouldAssumeContentIsAlwaysEditable(shouldAssumeContentIsAlwaysEditable)
@@ -57,12 +57,20 @@ void RemoveNodeCommand::doApply()
void RemoveNodeCommand::doUnapply()
{
- RefPtr<ContainerNode> parent = m_parent.release();
- RefPtr<Node> refChild = m_refChild.release();
+ RefPtrWillBeRawPtr<ContainerNode> parent = m_parent.release();
+ RefPtrWillBeRawPtr<Node> refChild = m_refChild.release();
if (!parent || !parent->rendererIsEditable())
return;
parent->insertBefore(m_node.get(), refChild.get(), IGNORE_EXCEPTION);
}
+void RemoveNodeCommand::trace(Visitor* visitor)
+{
+ visitor->trace(m_node);
+ visitor->trace(m_parent);
+ visitor->trace(m_refChild);
+ SimpleEditCommand::trace(visitor);
+}
+
}
« no previous file with comments | « Source/core/editing/RemoveNodeCommand.h ('k') | Source/core/editing/RemoveNodePreservingChildrenCommand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698