Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: Source/core/editing/MoveSelectionCommand.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make test wrapper class finalized Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/MergeIdenticalElementsCommand.cpp ('k') | Source/core/editing/MoveSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/MoveSelectionCommand.h
diff --git a/Source/core/editing/MoveSelectionCommand.h b/Source/core/editing/MoveSelectionCommand.h
index 60a06b34b5f95cb7661b3e4c02c0e00dfbb85e13..dd55c6f759234e0432b7854c81a45b416b214ba2 100644
--- a/Source/core/editing/MoveSelectionCommand.h
+++ b/Source/core/editing/MoveSelectionCommand.h
@@ -34,18 +34,20 @@ class DocumentFragment;
class MoveSelectionCommand FINAL : public CompositeEditCommand {
public:
- static PassRefPtr<MoveSelectionCommand> create(PassRefPtrWillBeRawPtr<DocumentFragment> fragment, const Position& position, bool smartInsert = false, bool smartDelete = false)
+ static PassRefPtrWillBeRawPtr<MoveSelectionCommand> create(PassRefPtrWillBeRawPtr<DocumentFragment> fragment, const Position& position, bool smartInsert = false, bool smartDelete = false)
{
- return adoptRef(new MoveSelectionCommand(fragment, position, smartInsert, smartDelete));
+ return adoptRefWillBeNoop(new MoveSelectionCommand(fragment, position, smartInsert, smartDelete));
}
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
MoveSelectionCommand(PassRefPtrWillBeRawPtr<DocumentFragment>, const Position&, bool smartInsert, bool smartDelete);
virtual void doApply() OVERRIDE;
virtual EditAction editingAction() const OVERRIDE;
- RefPtrWillBePersistent<DocumentFragment> m_fragment;
+ RefPtrWillBeMember<DocumentFragment> m_fragment;
Position m_position;
bool m_smartInsert;
bool m_smartDelete;
« no previous file with comments | « Source/core/editing/MergeIdenticalElementsCommand.cpp ('k') | Source/core/editing/MoveSelectionCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698