Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: Source/core/editing/InsertLineBreakCommand.cpp

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make test wrapper class finalized Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/InsertLineBreakCommand.h ('k') | Source/core/editing/InsertListCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/InsertLineBreakCommand.cpp
diff --git a/Source/core/editing/InsertLineBreakCommand.cpp b/Source/core/editing/InsertLineBreakCommand.cpp
index dc10873ba4a19da0da5ad8fb8db7d52c2cc14df2..2c3c86644721668012ddab73814c0ebc8e21ef01 100644
--- a/Source/core/editing/InsertLineBreakCommand.cpp
+++ b/Source/core/editing/InsertLineBreakCommand.cpp
@@ -81,7 +81,7 @@ void InsertLineBreakCommand::doApply()
pos = positionOutsideTabSpan(pos);
- RefPtr<Node> nodeToInsert;
+ RefPtrWillBeRawPtr<Node> nodeToInsert = nullptr;
if (shouldUseBreakElement(pos))
nodeToInsert = createBreakElement(document());
else
@@ -141,7 +141,7 @@ void InsertLineBreakCommand::doApply()
// Handle the case where there is a typing style.
- RefPtr<EditingStyle> typingStyle = document().frame()->selection().typingStyle();
+ RefPtrWillBeRawPtr<EditingStyle> typingStyle = document().frame()->selection().typingStyle();
if (typingStyle && !typingStyle->isEmpty()) {
// Apply the typing style to the inserted line break, so that if the selection
« no previous file with comments | « Source/core/editing/InsertLineBreakCommand.h ('k') | Source/core/editing/InsertListCommand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698