Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: Source/core/editing/EditCommand.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make test wrapper class finalized Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/DeleteSelectionCommand.cpp ('k') | Source/core/editing/EditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/EditCommand.h
diff --git a/Source/core/editing/EditCommand.h b/Source/core/editing/EditCommand.h
index 7db7351f9e8f8ad5f5c16ffb82b9e50f31b70099..4b9a2ec49dd8f794462c19c7df24870e334f5bc9 100644
--- a/Source/core/editing/EditCommand.h
+++ b/Source/core/editing/EditCommand.h
@@ -28,6 +28,7 @@
#include "core/editing/EditAction.h"
#include "core/editing/VisibleSelection.h"
+#include "platform/heap/Handle.h"
#ifndef NDEBUG
#include "wtf/HashSet.h"
@@ -39,7 +40,7 @@ class CompositeEditCommand;
class Document;
class Element;
-class EditCommand : public RefCounted<EditCommand> {
+class EditCommand : public RefCountedWillBeGarbageCollectedFinalized<EditCommand> {
public:
virtual ~EditCommand();
@@ -56,6 +57,8 @@ public:
virtual void doApply() = 0;
+ virtual void trace(Visitor*);
+
protected:
explicit EditCommand(Document&);
EditCommand(Document*, const VisibleSelection&, const VisibleSelection&);
@@ -68,10 +71,10 @@ protected:
void setEndingSelection(const VisiblePosition&);
private:
- RefPtr<Document> m_document;
+ RefPtrWillBeMember<Document> m_document;
VisibleSelection m_startingSelection;
VisibleSelection m_endingSelection;
- CompositeEditCommand* m_parent;
+ RawPtrWillBeMember<CompositeEditCommand> m_parent;
};
enum ShouldAssumeContentIsAlwaysEditable {
« no previous file with comments | « Source/core/editing/DeleteSelectionCommand.cpp ('k') | Source/core/editing/EditCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698