Oilpan: move editing objects to the heap.

Source/core/editing/EditCommand.h

Index: Source/core/editing/EditCommand.h
diff --git a/Source/core/editing/EditCommand.h b/Source/core/editing/EditCommand.h
index 7db7351f9e8f8ad5f5c16ffb82b9e50f31b70099..b2aef7f68b55d6e32e7fffebb6cbb38ae4f1d88f 100644
--- a/Source/core/editing/EditCommand.h
+++ b/Source/core/editing/EditCommand.h
@@ -28,6 +28,7 @@
 
 #include "core/editing/EditAction.h"
 #include "core/editing/VisibleSelection.h"
+#include "platform/heap/Handle.h"
 
 #ifndef NDEBUG
 #include "wtf/HashSet.h"
@@ -39,7 +40,7 @@ class CompositeEditCommand;
 class Document;
 class Element;
 
-class EditCommand : public RefCounted<EditCommand> {
+class EditCommand : public RefCountedWillBeGarbageCollectedFinalized<EditCommand> {
 public:
     virtual ~EditCommand();
 
@@ -56,6 +57,8 @@ public:
 
     virtual void doApply() = 0;
 
+    virtual void trace(Visitor*);
+
 protected:
     explicit EditCommand(Document&);
     EditCommand(Document*, const VisibleSelection&, const VisibleSelection&);
@@ -68,7 +71,7 @@ protected:
     void setEndingSelection(const VisiblePosition&);
 
 private:
-    RefPtr<Document> m_document;
+    RefPtrWillBeMember<Document> m_document;
     VisibleSelection m_startingSelection;
     VisibleSelection m_endingSelection;
     CompositeEditCommand* m_parent;

[haraken, 2014/05/26 02:36:12]

Shouldn't this be a Member, since CompositeEditCommand is now on the heap?

[sof, 2014/05/28 08:31:35]

Yes, now a Member. afaict, the command holding this parent object reference is
always stored in the command sequence on the parent itself, so it seems safe to
keep it raw pointer. But Member is preferable.