Oilpan: move editing objects to the heap.

Source/core/editing/Caret.h

Index: Source/core/editing/Caret.h
diff --git a/Source/core/editing/Caret.h b/Source/core/editing/Caret.h
index 3d9f9eba45c01a49fdb3a904a670547878173b25..d39905e98ad8a0079934be2c51576ed5e01dbb1a 100644
--- a/Source/core/editing/Caret.h
+++ b/Source/core/editing/Caret.h
@@ -40,7 +40,7 @@ class RenderView;
 
 class CaretBase {

[haraken, 2014/05/26 02:36:12]

CaretBase needs to be a GC mix-in once we move VisiblePosition to the heap
(DragCaretController has VisiblePosition as a part of object), but it looks OK
to keep CaretBase off-heap in this CL.

(I hope the plugin catches the error if we forget to make CaretBase a GC mix-in
when moving VisiblePosition to the heap.)

[sof, 2014/05/28 08:31:35]

Hmm, do we declare these kinds of private-inherited 'base' classes as GC mixins
even if derived objects of CaretBase are never stored as CaretBases?

Left it as-is.

     WTF_MAKE_NONCOPYABLE(CaretBase);
-    WTF_MAKE_FAST_ALLOCATED;
+    WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
 protected:
     enum CaretVisibility { Visible, Hidden };
     explicit CaretBase(CaretVisibility = Hidden);
@@ -73,7 +73,7 @@ private:
 
 class DragCaretController : private CaretBase {
     WTF_MAKE_NONCOPYABLE(DragCaretController);
-    WTF_MAKE_FAST_ALLOCATED;
+    WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
 public:
     static PassOwnPtr<DragCaretController> create();