Oilpan: move editing objects to the heap.

Source/core/editing/VisibleSelection.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 118 matching lines @@
     m_affinity = other.m_affinity;
     m_changeObserver = 0;
     m_selectionType = other.m_selectionType;
     m_baseIsFirst = other.m_baseIsFirst;
     m_isDirectional = other.m_isDirectional;
     return *this;
 }
 
 VisibleSelection::~VisibleSelection()
 {
     didChange();

[haraken, 2014/05/28 15:35:25]

This touches another on-heap object. If you make m_changeObserver a WeakMember,
I think you can just remove didChange() from here.

[sof, 2014/05/28 22:06:06]

I'm not sure the generality of a WeakMember is warranted here -- the only place
a ChangeObserver is set is for FrameSelection::m_selection, which is a part
object of the FrameSelection observer. I think we can wait and see a bit before
generalizing..?

 }
 
 VisibleSelection VisibleSelection::selectionFromContentsOfNode(Node* node)
 {
     ASSERT(!editingIgnoresContent(node));
     return VisibleSelection(firstPositionInNode(node), lastPositionInNode(node), DOWNSTREAM);
 }
 
 void VisibleSelection::setBase(const Position& position)
 {
@@ skipping 603 matching lines @@
     ASSERT(m_changeObserver);
     m_changeObserver = 0;
 }
 
 void VisibleSelection::didChange()
 {
     if (m_changeObserver)
         m_changeObserver->didChangeVisibleSelection();
 }
 
+void VisibleSelection::trace(Visitor* visitor)
+{
+    visitor->trace(m_base);
+    visitor->trace(m_extent);
+    visitor->trace(m_start);
+    visitor->trace(m_end);
+}
+
 #ifndef NDEBUG
 
 void VisibleSelection::debugPosition() const
 {
     fprintf(stderr, "VisibleSelection ===============\n");
 
     if (!m_start.anchorNode())
         fputs("pos:   null", stderr);
     else if (m_start == m_end) {
         fprintf(stderr, "pos:   %s ", m_start.anchorNode()->nodeName().utf8().data());
@@ skipping 51 matching lines @@
     sel.showTreeForThis();
 }
 
 void showTree(const WebCore::VisibleSelection* sel)
 {
     if (sel)
         sel->showTreeForThis();
 }
 
 #endif