Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: Source/core/editing/MoveSelectionCommand.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 16 matching lines...) Expand all
27 #define MoveSelectionCommand_h 27 #define MoveSelectionCommand_h
28 28
29 #include "core/editing/CompositeEditCommand.h" 29 #include "core/editing/CompositeEditCommand.h"
30 30
31 namespace WebCore { 31 namespace WebCore {
32 32
33 class DocumentFragment; 33 class DocumentFragment;
34 34
35 class MoveSelectionCommand FINAL : public CompositeEditCommand { 35 class MoveSelectionCommand FINAL : public CompositeEditCommand {
36 public: 36 public:
37 static PassRefPtr<MoveSelectionCommand> create(PassRefPtrWillBeRawPtr<Docume ntFragment> fragment, const Position& position, bool smartInsert = false, bool s martDelete = false) 37 static PassRefPtrWillBeRawPtr<MoveSelectionCommand> create(PassRefPtrWillBeR awPtr<DocumentFragment> fragment, const Position& position, bool smartInsert = f alse, bool smartDelete = false)
38 { 38 {
39 return adoptRef(new MoveSelectionCommand(fragment, position, smartInsert , smartDelete)); 39 return adoptRefWillBeNoop(new MoveSelectionCommand(fragment, position, s martInsert, smartDelete));
40 } 40 }
41 41
42 virtual void trace(Visitor*) OVERRIDE;
43
42 private: 44 private:
43 MoveSelectionCommand(PassRefPtrWillBeRawPtr<DocumentFragment>, const Positio n&, bool smartInsert, bool smartDelete); 45 MoveSelectionCommand(PassRefPtrWillBeRawPtr<DocumentFragment>, const Positio n&, bool smartInsert, bool smartDelete);
44 46
45 virtual void doApply() OVERRIDE; 47 virtual void doApply() OVERRIDE;
46 virtual EditAction editingAction() const OVERRIDE; 48 virtual EditAction editingAction() const OVERRIDE;
47 49
48 RefPtrWillBePersistent<DocumentFragment> m_fragment; 50 RefPtrWillBeMember<DocumentFragment> m_fragment;
49 Position m_position; 51 Position m_position;
haraken 2014/05/26 02:36:12 You need to trace m_position.
sof 2014/05/28 08:31:35 Done.
50 bool m_smartInsert; 52 bool m_smartInsert;
51 bool m_smartDelete; 53 bool m_smartDelete;
52 }; 54 };
53 55
54 } // namespace WebCore 56 } // namespace WebCore
55 57
56 #endif // MoveSelectionCommand_h 58 #endif // MoveSelectionCommand_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698