Issue 299353002: Roll in latest pdfium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299353002: Roll in latest pdfium. (Closed)

Created:
6 years, 7 months ago by jam

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Roll in latest pdfium. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272860

Patch Set 2 : sync #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -325 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	build/all.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	pdf/pdf.gyp	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download
D	pdf/pdfium/pdfium_test.cc	View	1	1 chunk	+0 lines, -312 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/299353002/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/299353002/diff/1/build/all.gyp#newcode30 build/all.gyp:30: '../third_party/pdfium/samples/samples.gyp:*', does it build on ios? might need ...

6 years, 7 months ago (2014-05-24 02:41:39 UTC) #2

jam

6 years, 6 months ago (2014-05-26 19:57:44 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/299353002/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/299353002/diff/1/build/all.gyp#newcode30
build/all.gyp:30: '../third_party/pdfium/samples/samples.gyp:*',
On 2014/05/24 02:41:39, scottmg wrote:
> does it build on ios? might need to go in a !ios block below

removed from ios/android

Expand Messages | Collapse Messages

Issue 299353002: Roll in latest pdfium. (Closed)

Description

Patch Set 1 #

Patch Set 2 : sync #

Messages