Issue 2993493002: Remove warnings when building the dart2js sdk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2993493002: Remove warnings when building the dart2js sdk. (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 4 months ago

Reviewers:
zra, sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove warnings when building the dart2js sdk. Also make the script exit with error code if any other warnings of this kind are seen. Fixes #30282 #30157 R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/62d1d28428ccdcdf76cd65d347f7f8d3489a92f8

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	tools/patch_sdk.dart	View	1	2 chunks	+19 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Siggi Cherem (dart-lang)

3 years, 4 months ago (2017-07-31 22:48:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:40001) manually as
62d1d28428ccdcdf76cd65d347f7f8d3489a92f8 (presubmit successful).