Add CallType to DynamicCallSiteTypeInformation

Add CallType to DynamicCallSiteTypeInformation

- to avoid using that type of the call node to determine how type masks
are stored in the GlobalTypeInferenceElementData.

This prepares for using arbitrary values (ast or ir nodes) as keys in
GlobalTypeInferenceElementData.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/f19ee6c9bf2617c3d127352c0f7bf408f42203e7

[Johnni Winther, 2017-07-31 13:33:40]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-07-31 19:30:29]

lgtm

https://codereview.chromium.org/2993463002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right):

https://codereview.chromium.org/2993463002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:392: /*if (node.asSendSet()
!= null) {
delete old code

https://codereview.chromium.org/2993463002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/2993463002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:834: bool
validCallType(CallType callType, Spannable call) {
I didn't see this used. Should this replace all the asserts in
updateSelectorInMember?

[Johnni Winther, 2017-08-01 07:31:57]

Description was changed from

==========
Add CallType to DynamicCallSiteTypeInformation

- to avoid using that type of the call node to determine how type masks
are stored in the GlobalTypeInferenceElementData.

This prepares for using arbitrary values (ast or ir nodes) as keys in
GlobalTypeInferenceElementData.
==========

to

==========
Add CallType to DynamicCallSiteTypeInformation

- to avoid using that type of the call node to determine how type masks
are stored in the GlobalTypeInferenceElementData.

This prepares for using arbitrary values (ast or ir nodes) as keys in
GlobalTypeInferenceElementData.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f19ee6c9bf2617c3d127352c0f7bf408f42203e7
==========

[Johnni Winther, 2017-08-01 07:31:58]

Committed patchset #2 (id:20001) manually as
f19ee6c9bf2617c3d127352c0f7bf408f42203e7 (presubmit successful).

[Johnni Winther, 2017-08-01 13:09:20]

https://codereview.chromium.org/2993463002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right):

https://codereview.chromium.org/2993463002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:392: /*if (node.asSendSet()
!= null) {
On 2017/07/31 19:30:29, Siggi Cherem (dart-lang) wrote:
> delete old code

Done.

https://codereview.chromium.org/2993463002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/2993463002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:834: bool
validCallType(CallType callType, Spannable call) {
On 2017/07/31 19:30:29, Siggi Cherem (dart-lang) wrote:
> I didn't see this used. Should this replace all the asserts in
> updateSelectorInMember?

Used in DynamicCallSiteTypeInformation constructor (and now in
updateSelectorInMember as well)