Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2993383002: [vm] Compute per-HeapPage usage during sweeping. (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
danunez, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm] Compute per-HeapPage usage during sweeping. To be used by compacting GC. R=asiva@google.com, danunez@google.com Committed: https://github.com/dart-lang/sdk/commit/7af0a05a2ec6ec55d4a4f6e4e2e750a3170c33e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M runtime/vm/gc_sweeper.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/pages.h View 3 chunks +9 lines, -3 lines 0 comments Download
M runtime/vm/pages.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
3 years, 4 months ago (2017-08-10 18:17:57 UTC) #2
danunez
lgtm w/ comment Why collect in terms in bytes instead of words, like we do ...
3 years, 4 months ago (2017-08-10 18:20:40 UTC) #3
siva
lgtm
3 years, 4 months ago (2017-08-10 21:04:18 UTC) #4
rmacnak
On 2017/08/10 18:20:40, danunez wrote: > lgtm w/ comment > > Why collect in terms ...
3 years, 4 months ago (2017-08-11 19:39:44 UTC) #5
rmacnak
3 years, 4 months ago (2017-08-11 20:06:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7af0a05a2ec6ec55d4a4f6e4e2e750a3170c33e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698