Add a hint to rename .analysis_options files.

Add a hint to rename .analysis_options files.

BUG=
R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/69afd51bbe60f1450c8c3470b08fcd4866de84c4

[devoncarew, 2017-08-09 05:49:58]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, danrubel@google.com

[devoncarew, 2017-08-09 05:49:59]

Add a hint to rename .analysis_options files to analysis_options.yaml.

(partial redux of https://codereview.chromium.org/2654043003/)

[devoncarew, 2017-08-09 05:59:38]

On 2017/08/09 05:49:59, devoncarew wrote:
> Add a hint to rename .analysis_options files to analysis_options.yaml.
> 
> (partial redux of https://codereview.chromium.org/2654043003/)

The hint message is: "The name of the analysis options file .analysis_options is
deprecated; consider renaming it to analysis_options.yaml.".

[Brian Wilkerson, 2017-08-09 13:45:58]

This is not quite complete.

There is a global list of error codes that needs to be updated to include the
new code.

There is a test that knows the locations of files containing subclasses of
ErrorCode that verifies that the global list is complete. It probably needs to
be updated to find the new subclass.

There is a version field in Analysis driver that needs to be updated every time
a new error code is introduced.

[devoncarew, 2017-08-09 16:43:50]

On 2017/08/09 13:45:58, Brian Wilkerson wrote:
> This is not quite complete.
> 
> There is a global list of error codes that needs to be updated to include the
> new code.
> 
> There is a test that knows the locations of files containing subclasses of
> ErrorCode that verifies that the global list is complete. It probably needs to
> be updated to find the new subclass.
> 
> There is a version field in Analysis driver that needs to be updated every
time
> a new error code is introduced.

I found the global list, and the version field, but was unable to locate the
subclass test.

Also, is there something I need to do to make sure that the hint can be
resurrected from summary files?

[devoncarew, 2017-08-09 16:44:00]

devoncarew@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-08-09 16:59:17]

Does it work with Analysis Driver?
It changes tasks, and I cannot find whether we use it with AnalysisContext.

[devoncarew, 2017-08-09 17:06:15]

On 2017/08/09 16:59:17, scheglov wrote:
> Does it work with Analysis Driver?
> It changes tasks, and I cannot find whether we use it with AnalysisContext.

I am wholly unfamiliar with this code, but it does show the warning for the
older file name. Perhaps this bit of the tasks codebase is being driven by the
driver?

[scheglov, 2017-08-09 17:09:42]

LGTM

OK, I see now - the task is used in ContextManagerImpl in Analysis Server.

[Brian Wilkerson, 2017-08-09 17:12:55]

The subclass test is in analyzer/test/src/task/options_test.dart

[devoncarew, 2017-08-09 17:23:42]

Thanks for the info! I found the list of files in
pkg/analyzer/test/error/error_test.dart; it looks like that file is already in
the list.

[Brian Wilkerson, 2017-08-09 17:25:54]

lgtm, thanks!

[danrubel, 2017-08-09 18:04:29]

LGTM!

[devoncarew, 2017-08-09 18:48:36]

Description was changed from

==========
Add a hint to rename .analysis_options files.

BUG=
==========

to

==========
Add a hint to rename .analysis_options files.

BUG=
R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/69afd51bbe60f1450c8c3470b08fcd4866de84c4
==========

[devoncarew, 2017-08-09 18:48:37]

Committed patchset #2 (id:20001) manually as
69afd51bbe60f1450c8c3470b08fcd4866de84c4 (presubmit successful).