Issue 2993303002: Don't schedule timer if knownFilesSetChanges stream is not requested.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2993303002: Don't schedule timer if knownFilesSetChanges stream is not requested. (Closed)

Created:
3 years, 4 months ago by scheglov

Modified:
3 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't schedule timer if knownFilesSetChanges stream is not requested. I think this will helps up work the leak around. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1bd19697fc84dc0ce0084299d5780f949b487326

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/file_state.dart	View		4 chunks	+20 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 4 months ago (2017-08-08 21:40:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1bd19697fc84dc0ce0084299d5780f949b487326 (presubmit successful).