Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2993283002: Use LibraryBuilder.target for imports/exports. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 4 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 4 months ago (2017-08-08 16:18:11 UTC) #1
Paul Berry
lgtm
3 years, 4 months ago (2017-08-08 16:34:24 UTC) #2
ahe
lgtm
3 years, 4 months ago (2017-08-08 17:29:11 UTC) #3
scheglov
3 years, 4 months ago (2017-08-08 17:57:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
461ef144aba2d89cd103db7558f9f1fcc70cd097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698