Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7883)

Unified Diff: chrome/browser/ui/webui/certificate_viewer_webui.cc

Issue 299323002: Modified the certificate details viewers to include the timezone in the certificates validity dates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/certificate_viewer_webui.cc
diff --git a/chrome/browser/ui/webui/certificate_viewer_webui.cc b/chrome/browser/ui/webui/certificate_viewer_webui.cc
index f67d3498bf7798367c0957fbdcdde62f90f54064..60fee836be7f5f7e7d6c06171861a823ba11ea04 100644
--- a/chrome/browser/ui/webui/certificate_viewer_webui.cc
+++ b/chrome/browser/ui/webui/certificate_viewer_webui.cc
@@ -347,10 +347,11 @@ void CertificateViewerDialogHandler::RequestCertificateFields(
l10n_util::GetStringUTF8(IDS_CERT_DETAILS_NOT_AFTER));
base::Time issued, expires;
if (x509_certificate_model::GetTimes(cert, &issued, &expires)) {
+ //The object Time internally save the time in UTC timezone.
jww 2014/05/27 17:25:34 Please add a space before the comment per Chromium
node_details->SetString("payload.val",
- base::UTF16ToUTF8(base::TimeFormatShortDateAndTime(issued)));
+ base::UTF16ToUTF8(base::TimeFormatShortDateAndTime(issued)) + " (UTC)");
jww 2014/05/27 17:25:34 This should probably be internationalized.
alt_node_details->SetString("payload.val",
- base::UTF16ToUTF8(base::TimeFormatShortDateAndTime(expires)));
+ base::UTF16ToUTF8(base::TimeFormatShortDateAndTime(expires)) + " (UTC)");
jww 2014/05/27 17:25:34 See above comment on 352.
}
cert_fields->Append(node_details = new base::DictionaryValue());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698