Modified the certificate details viewers to include the timezone in the certificates validity dates.

Modified the certificate details viewers to include the timezone in the certificates validity dates.

Now when you check the certificate details and go to validity you will find the creation and expiration times reported in UTC timezone.

BUG=200243
R=jww@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273782

[jww, 2014-05-27 17:25:34]

https://codereview.chromium.org/299323002/diff/1/chrome/browser/ui/webui/cert...
File chrome/browser/ui/webui/certificate_viewer_webui.cc (right):

https://codereview.chromium.org/299323002/diff/1/chrome/browser/ui/webui/cert...
chrome/browser/ui/webui/certificate_viewer_webui.cc:350: //The object Time
internally save the time in UTC timezone.
Please add a space before the comment per Chromium code style. Also, please
correct "save" to "saves". I'd also add some explanation about "this is why the
(UTC) string is concatenated."

https://codereview.chromium.org/299323002/diff/1/chrome/browser/ui/webui/cert...
chrome/browser/ui/webui/certificate_viewer_webui.cc:352:
base::UTF16ToUTF8(base::TimeFormatShortDateAndTime(issued)) + " (UTC)");
This should probably be internationalized.

https://codereview.chromium.org/299323002/diff/1/chrome/browser/ui/webui/cert...
chrome/browser/ui/webui/certificate_viewer_webui.cc:354:
base::UTF16ToUTF8(base::TimeFormatShortDateAndTime(expires)) + " (UTC)");
See above comment on 352.

[mhm, 2014-05-27 22:55:22]

Made the changes to fix formatting and internationalization.

[jww, 2014-05-27 23:43:29]

lgtm with nits.

https://codereview.chromium.org/299323002/diff/20001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/299323002/diff/20001/chrome/app/generated_res...
chrome/app/generated_resources.grd:2730: (UTC)
nit: I'd rename this to IDS_CERT_DETAILS_UTC_TIMEZONE since it's really
specifying one specific timezone.

https://codereview.chromium.org/299323002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/certificate_viewer_webui.cc (right):

https://codereview.chromium.org/299323002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/certificate_viewer_webui.cc:355:
l10n_util::GetStringUTF8(IDS_CERT_DETAILS_VALIDITY_TIMEZONE));
Change these two variable references as mentioned in my generated_resources.grd
comment.

[mhm, 2014-05-28 00:02:44]

https://codereview.chromium.org/299323002/diff/20001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/299323002/diff/20001/chrome/app/generated_res...
chrome/app/generated_resources.grd:2730: (UTC)
On 2014/05/27 23:43:29, jww wrote:
> nit: I'd rename this to IDS_CERT_DETAILS_UTC_TIMEZONE since it's really
> specifying one specific timezone.

Done.

https://codereview.chromium.org/299323002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/certificate_viewer_webui.cc (right):

https://codereview.chromium.org/299323002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/certificate_viewer_webui.cc:355:
l10n_util::GetStringUTF8(IDS_CERT_DETAILS_VALIDITY_TIMEZONE));
On 2014/05/27 23:43:29, jww wrote:
> Change these two variable references as mentioned in my
generated_resources.grd
> comment.

Done.

[mhm, 2014-05-28 00:06:50]

jhawkins@ can you please OWNER review this for me?

Thanks,

[mhm, 2014-05-28 00:07:53]

jhawkins@ can you please OWNER review this for me?

Thanks,

[James Hawkins, 2014-05-30 00:27:10]

lgtm

[mhm, 2014-05-30 00:50:30]

The CQ bit was checked by mohammed@chromium.org

[commit-bot: I haz the power, 2014-05-30 00:53:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohammed@chromium.org/299323002/40001

[commit-bot: I haz the power, 2014-05-30 10:15:43]

Change committed as 273782