Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2993203002: Changes calculation of Scavenger's UsedInWords (Closed)

Created:
3 years, 4 months ago by danunez
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Changes calculation of Scavenger's UsedInWords Once again fixes https://github.com/dart-lang/sdk/issues/30311 The previous commit for this issue (044f818f014) was reverted to fix a bug. This CL avoids writing to the TLAB to measure the usage. R=asiva@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/91470e721167f9ab74273bf5398ae94a88ee4188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M runtime/vm/scavenger.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danunez
3 years, 4 months ago (2017-08-07 21:24:37 UTC) #1
rmacnak
lgtm
3 years, 4 months ago (2017-08-07 21:51:04 UTC) #2
danunez
3 years, 4 months ago (2017-08-07 22:17:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91470e721167f9ab74273bf5398ae94a88ee4188 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698