Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(48)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: pkg/front_end/testcases/reorder_super.dart
Issue
2993193002
:
When reordering constructor initializers, use correct types for temp vars. (Closed)
Patch Set:
Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
pkg/front_end/lib/src/fasta/kernel/body_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
pkg/front_end/lib/src/fasta/source/diet_listener.dart
pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
pkg/front_end/testcases/ast_builder.status
pkg/front_end/testcases/reorder_super.dart
pkg/front_end/testcases/reorder_super.dart.direct.expect
pkg/front_end/testcases/reorder_super.dart.outline.expect
pkg/front_end/testcases/reorder_super.dart.strong.expect
View unified diff
|
Download patch
« pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
('K') |
« pkg/front_end/testcases/ast_builder.status
('k') |
pkg/front_end/testcases/reorder_super.dart.direct.expect »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2
// for details. All rights reserved. Use of this source code is governed by a
3
// BSD-style license that can be found in the LICENSE file.
4
5
// This test verifies that super calls get reordered properly. It exercises the
6
// case where the arguments to super have a type other than `dynamic`.
7
String events = '';
8
9
int f(x) {
10
events += 'f($x)\n';
11
return 0;
12
}
13
14
String g(x) {
15
events += 'g($x)\n';
16
return 'foo';
17
}
18
19
class B {
20
num x;
21
String y;
22
B(this.x, this.y) {
23
events += 'super($x, $y)\n';
24
}
25
}
26
27
class C extends B {
28
final z;
29
C()
30
: super(f(1), g(2)),
31
z = f(3);
32
}
33
34
main() {
35
new C();
36
if (events != 'f(1)\ng(2)\nf(3)\nsuper(0, foo)\n') {
37
throw 'Unexpected sequence of events: $events';
38
}
39
}
OLD
NEW
« pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
('K') |
« pkg/front_end/testcases/ast_builder.status
('k') |
pkg/front_end/testcases/reorder_super.dart.direct.expect »
('j') |
no next file with comments »
Issue 2993193002: When reordering constructor initializers, use correct types for temp vars. (Closed)
Created 3 years, 4 months ago by Paul Berry
Modified 3 years, 4 months ago
Reviewers: ahe, scheglov
Base URL:
Comments: 3
This is Rietveld
408576698