Issue 2993153002: Use analyzeOnly in kernel/impact_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2993153002: Use analyzeOnly in kernel/impact_test. (Closed)

Created:
3 years, 4 months ago by Johnni Winther

Modified:
3 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use analyzeOnly in kernel/impact_test. This is needed to ensure correct handling of native data in impact computation. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/d1966978d16a5d79a6cf6882a2392166d2310ed3

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -87 lines)			Patch
M	pkg/compiler/lib/src/common/resolution.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/compiler_helper.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/impact_test.dart	View	1	3 chunks	+69 lines, -80 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 4 months ago (2017-08-09 08:25:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d1966978d16a5d79a6cf6882a2392166d2310ed3 (presubmit successful).