Issue 299313011: Make sure webrtc::VideoSource is released when WebRtcVideoTrackAdapter is destroyed.

Issue 299313011: Make sure webrtc::VideoSource is released when WebRtcVideoTrackAdapter is destroyed. (Closed)

Created:
6 years, 6 months ago by perkj_chrome

Modified:
6 years, 6 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make sure webrtc::VideoSource is released when WebRtcVideoTrackAdapter is destroyed. This is to ensure that the webrtc::VideoSource is destroyed before the PeerConnectionFactory is destroyed in RenderThreadImpl::ShutDown. COLLABORATOR=tommi@chromium.org BUG=378179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273869

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Added comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -16 lines)			Patch
	M	content/renderer/media/webrtc/webrtc_video_track_adapter.cc	View	1 2	8 chunks	+38 lines, -16 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

lgtm https://codereview.chromium.org/299313011/diff/20001/content/renderer/media/webrtc/webrtc_video_track_adapter.cc File content/renderer/media/webrtc/webrtc_video_track_adapter.cc (right): https://codereview.chromium.org/299313011/diff/20001/content/renderer/media/webrtc/webrtc_video_track_adapter.cc#newcode38 content/renderer/media/webrtc/webrtc_video_track_adapter.cc:38: void ReleaseSourceOnMainThread(); Can you add some notes on ...

6 years, 6 months ago (2014-05-30 11:15:22 UTC) #3

perkj_chrome

https://codereview.chromium.org/299313011/diff/20001/content/renderer/media/webrtc/webrtc_video_track_adapter.cc File content/renderer/media/webrtc/webrtc_video_track_adapter.cc (right): https://codereview.chromium.org/299313011/diff/20001/content/renderer/media/webrtc/webrtc_video_track_adapter.cc#newcode38 content/renderer/media/webrtc/webrtc_video_track_adapter.cc:38: void ReleaseSourceOnMainThread(); On 2014/05/30 11:15:22, tommi wrote: > Can ...

6 years, 6 months ago (2014-05-30 12:16:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/299313011/50001

6 years, 6 months ago (2014-05-30 12:19:40 UTC) #6

Message was sent while issue was closed.

Change committed as 273869

Expand Messages | Collapse Messages