Issue 299313005: Replace bare ICU run iterator with base::i18n::BiDiLineIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299313005: Replace bare ICU run iterator with base::i18n::BiDiLineIterator (Closed)

Created:
6 years, 7 months ago by ckocagil

Modified:
6 years, 7 months ago

Reviewers:
msw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Replace bare ICU run iterator with base::i18n::BiDiLineIterator Also simplifies text run direction logic. BUG=321868 R=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273159

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -44 lines)			Patch
	M	ui/gfx/render_text_harfbuzz.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/gfx/render_text_harfbuzz.cc	View		11 chunks	+24 lines, -43 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/299313005/1

6 years, 7 months ago (2014-05-28 01:02:40 UTC) #4

Message was sent while issue was closed.

Change committed as 273159