Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2993123003: Fix analyzer status for cast_test. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix analyzer status for cast_test. Also add another configuration in the migration test runner to catch this in the future. Committed: https://github.com/dart-lang/sdk/commit/850b80a84eb74e56103979bacf7c482f992f7875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tests/language_2/language_2_analyzer.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/migration/bin/run_tests.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
TBR.
3 years, 4 months ago (2017-08-05 01:37:05 UTC) #2
Bob Nystrom
Committed patchset #1 (id:1) manually as 850b80a84eb74e56103979bacf7c482f992f7875 (presubmit successful).
3 years, 4 months ago (2017-08-05 01:37:23 UTC) #4
Jennifer Messerly
3 years, 4 months ago (2017-08-07 22:34:16 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698