Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2993113003: Revert "Switch FE to use the libraries.json format." (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Switch FE to use the libraries.json format." This reverts commit abf2d23af2315fae6dc688741147ef677ec34835. Reason for revert: - win build failed in patched_sdk (likely storing paths and not uris) - dart2js bots failed (missing flag) Will fix the issues and reland shortly. Committed: https://github.com/dart-lang/sdk/commit/b6d08264a3209043d58a745a0c85fa331fc9f5f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -871 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart View 3 chunks +14 lines, -0 lines 0 comments Download
M pkg/front_end/lib/compiler_options.dart View 1 chunk +10 lines, -9 lines 0 comments Download
M pkg/front_end/lib/incremental_kernel_generator.dart View 2 chunks +4 lines, -7 lines 0 comments Download
D pkg/front_end/lib/src/base/libraries_specification.dart View 1 chunk +0 lines, -221 lines 0 comments Download
M pkg/front_end/lib/src/base/processed_options.dart View 5 chunks +32 lines, -83 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 2 chunks +0 lines, -51 lines 0 comments Download
M pkg/front_end/lib/src/fasta/uri_translator_impl.dart View 3 chunks +70 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/testing/compiler_common.dart View 2 chunks +7 lines, -19 lines 0 comments Download
M pkg/front_end/messages.yaml View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/uri_translator_test.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/test/kernel_generator_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
D pkg/front_end/test/src/base/libraries_specification_test.dart View 1 chunk +0 lines, -309 lines 0 comments Download
M pkg/front_end/test/src/base/processed_options_test.dart View 3 chunks +2 lines, -57 lines 0 comments Download
M pkg/front_end/test/src/incremental/file_state_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart View 1 chunk +11 lines, -1 line 0 comments Download
M pkg/front_end/test/src/incremental/kernel_driver_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/test/src/incremental/mock_sdk.dart View 2 chunks +7 lines, -15 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M tools/patch_sdk.dart View 9 chunks +16 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Siggi Cherem (dart-lang)
TBR
3 years, 4 months ago (2017-08-05 02:45:57 UTC) #2
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-05 02:46:24 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b6d08264a3209043d58a745a0c85fa331fc9f5f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698